Bug 2155624 - Review Request: rust-tracing_facade - Facade for tracing
Summary: Review Request: rust-tracing_facade - Facade for tracing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2155628 2155631 ITP-rust-pore
TreeView+ depends on / blocked
 
Reported: 2022-12-21 16:38 UTC by Michel Lind
Modified: 2023-01-05 01:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-04 01:24:14 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-12-21 16:38:12 UTC
Spec URL: https://salimma.fedorapeople.org/rust-tracing_facade.spec
SRPM URL: https://salimma.fedorapeople.org/rust-tracing_facade-0.1.0-1.fc37.src.rpm

Description:
Facade for tracing.

Fedora Account System Username: salimma

Comment 1 Davide Cavalca 2022-12-22 08:53:22 UTC
This package doesn't include a license file. It's under 0BSD, which doesn't strictly require it, but nonetheless I'd recommend adding one and working with upstream to get that fixed.

Comment 2 Michel Lind 2022-12-22 20:08:16 UTC
License text added, and PR filed: https://github.com/jmgao/tracing/pull/4

Comment 3 Davide Cavalca 2022-12-22 20:09:55 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Michel Lind 2022-12-22 20:15:00 UTC
Thanks!

fedora/pkgs-sig-rust/pore 
⬢ [fedora-toolbox:37] ❯ set -gx C tracing_facade

fedora/pkgs-sig-rust/pore 
⬢ [fedora-toolbox:37] ❯ set -gx B 2155624

fedora/pkgs-sig-rust/pore 
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/49978

fedora/pkgs-sig-rust/pore took 5s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/49979

fedora/pkgs-sig-rust/pore took 5s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/49980
https://pagure.io/releng/fedora-scm-requests/issue/49981

Comment 5 Kevin Fenzi 2022-12-24 00:40:41 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tracing_facade

Comment 6 Fedora Update System 2023-01-03 00:27:33 UTC
FEDORA-EPEL-2023-ae11e26767 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767

Comment 7 Fedora Update System 2023-01-03 03:55:03 UTC
FEDORA-2023-815ee95850 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-815ee95850

Comment 8 Fedora Update System 2023-01-03 04:00:07 UTC
FEDORA-2023-74ed908696 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-74ed908696

Comment 9 Fedora Update System 2023-01-04 01:24:14 UTC
FEDORA-2023-74ed908696 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-01-04 01:32:38 UTC
FEDORA-2023-815ee95850 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-01-04 02:18:51 UTC
FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-01-05 01:46:37 UTC
FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.