Bug 2155640

Summary: pmars: Build in C89 mode because of internal inconsistency about sighandler definition
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: pmarsAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: gwync
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pmars-0.9.2-27.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-11 12:15:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137516    

Description Florian Weimer 2022-12-21 17:26:26 UTC 
The pmars package currently relies on an implicit declaration of the sighandler function for compiling src/xwindisp.c. Fixing this is kind of involved and likely not upstreamable given the prototype selection logic for sighandler, see src/pmars.c. So we should build this package in C89 mode for now.
Comment 1 Gwyn Ciesla 2022-12-21 19:13:06 UTC 
I see a commit and a build, is this resolved?
Comment 2 Florian Weimer 2023-01-11 12:15:01 UTC 
Yes, indeed it is, I forgot to close the bug.