Bug 2155640 - pmars: Build in C89 mode because of internal inconsistency about sighandler definition
Summary: pmars: Build in C89 mode because of internal inconsistency about sighandler d...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: pmars
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2022-12-21 17:26 UTC by Florian Weimer
Modified: 2023-08-16 09:26 UTC (History)
1 user (show)

Fixed In Version: pmars-0.9.2-27.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-11 12:15:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-936 0 None None None 2023-08-16 09:26:08 UTC

Description Florian Weimer 2022-12-21 17:26:26 UTC
The pmars package currently relies on an implicit declaration of the sighandler function for compiling src/xwindisp.c. Fixing this is kind of involved and likely not upstreamable given the prototype selection logic for sighandler, see src/pmars.c. So we should build this package in C89 mode for now.

Comment 1 Gwyn Ciesla 2022-12-21 19:13:06 UTC
I see a commit and a build, is this resolved?

Comment 2 Florian Weimer 2023-01-11 12:15:01 UTC
Yes, indeed it is, I forgot to close the bug.


Note You need to log in before you can comment on or make changes to this bug.