Bug 2156091
Summary: | Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Antonio T. sagitter <trpost> |
Component: | Package Review | Assignee: | Vasiliy Glazov <vascom2> |
Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | manisandro, package-review, vascom2 |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YBJ34UEXVAHUUMPQLOOJUSDYSYBHZ23D/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-01-01 15:01:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Antonio T. sagitter
2022-12-23 21:15:16 UTC
Just a quick suggestion for future-proofness / analogy with other Qt libraries: I'd call the base package qwtplot3d and then the subpackage qwtplot3d-qt6, which then allows you to add say qwtplot3d-qt7 without renaming the source repo or requiring an additional source repo. BTW, there appears to be no BR: qwt-qt6-devel or equivalent? 1. Need to change License name to Zlib. 2. Remove %global gittag %{commit} as unused. 3. Change Source0: https://github.com/SciDAVis/qwtplot3d/archive/%{commit}/qwtplot3d-%{commit}.tar.gz to Source0: %{url}/archive/%{commit}/qwtplot3d-%{commit}.tar.gz 4. It is really necessary? Requires: cmake(Qt6Core) Requires: cmake(Qt6Gui) 5. Change %autosetup -n qwtplot3d-%{commit} -N %patch0 -p1 -b .backup to %autosetup -p1 -n qwtplot3d-%{commit} -N 6. Change Buildrequires: to BuildRequires: 7. Need to review options list for %cmake because some of them not used: BUILD_EXAMPLES QT_QMAKE_EXECUTABLE QWT_INCLUDE_DIR QWT_LIBRARY QWT_VERSION_STRING SELECT_QT WITH_ZLIB 8. As I see zlib not used for build at all. (In reply to Sandro Mani from comment #1) > Just a quick suggestion for future-proofness / analogy with other Qt > libraries: I'd call the base package qwtplot3d and then the subpackage > qwtplot3d-qt6, which then allows you to add say qwtplot3d-qt7 without > renaming the source repo or requiring an additional source repo. BTW, there > appears to be no BR: qwt-qt6-devel or equivalent? I have re-named this package as qwtplot3d-qt Probably, a Qt5 sub-package could obsolete the `qwtplot3d-qt5` rpm (In reply to Vasiliy Glazov from comment #2) > > 5. Change > %autosetup -n qwtplot3d-%{commit} -N > > %patch0 -p1 -b .backup > to > %autosetup -p1 -n qwtplot3d-%{commit} -N I prefer to use the %%patch command apart. Let me work better to this package Why not just qwtplot3d? Packages should use the upstream name, and the Qt "q" is already in the q of qwt (Qt Widgets for Technical applications). (In reply to Sandro Mani from comment #5) > Why not just qwtplot3d? Packages should use the upstream name, and the Qt > "q" is already in the q of qwt (Qt Widgets for Technical applications). qwtplot3d already exists in Fedora Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and AFAICS no packages depend on either. What about switching that package to the more recent fork and dropping qt3/qt4? (In reply to Sandro Mani from comment #7) > Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and > AFAICS no packages depend on either. What about switching that package to > the more recent fork and dropping qt3/qt4? Yes, probably it's the better choice I'm closing this ticket. Thank you Vasiliy and Sandro |