Bug 215669

Summary: Define LIBDIR, BINDIR, etc. in Makefile
Product: [Retired] 389 Reporter: Rich Megginson <rmeggins>
Component: Directory ServerAssignee: Rich Megginson <rmeggins>
Status: CLOSED CURRENTRELEASE QA Contact: Viktor Ashirov <vashirov>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.0.2   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-07 17:17:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 152373, 240316, 427409    
Attachments:
Description Flags
diffs
none
cvs commit log none

Description Rich Megginson 2006-11-15 04:08:10 UTC 
Instead of hard-coding LIBDIR, BINDIR et. al. in create_instance.h, these should
be defined during make.  We can't define them during configure (with AC_DEFINE)
because the values of libdir, bindir, et. al. depend on $prefix and $exec_prefix
which may be set at make time.
Comment 1 Rich Megginson 2006-11-15 04:08:10 UTC 
Created attachment 141220 [details]
diffs
Comment 2 Rich Megginson 2006-11-15 17:18:18 UTC 
Created attachment 141286 [details]
cvs commit log

Reviewed by: nkinder (Thanks!)
Branch: HEAD
Fix Description: The paths LIBDIR, BINDIR, et. al. are #define'd in
create_instance.h to hard coded values.  We should be able to set these values
in configure and override the built in values.	We can't simply set them via
AC_DEFINE in configure.ac because we are using config.h and this would render
the definition like this:
#define BINDIR "${exec_prefix}/bin"
instead of
#define BINDIR "/usr/bin"
So we instead define them in Makefile.am and add their definitions to
AM_CPPFLAGS, and quote them properly to make sure the value includes the
quotation marks when expanded in the C code.  I tested this with both an
rpmbuild and a regular developer type build.
Platforms tested: RHEL4/FC5
Flag Day: no
Doc impact: no