Bug 2156960
| Summary: | Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, decathorpe, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-08 01:20:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2156961 | ||
|
Description
Michel Lind
2022-12-29 22:42:01 UTC
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. Thanks! src/fedora/pkgs-sig-rust ⬢ [fedora-toolbox:37] ❯ set -gx C wu-diff src/fedora/pkgs-sig-rust ⬢ [fedora-toolbox:37] ❯ set -gx B 2156960 src/fedora/pkgs-sig-rust ⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B https://pagure.io/releng/fedora-scm-requests/issue/50070 src/fedora/pkgs-sig-rust took 4s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9 https://pagure.io/releng/fedora-scm-requests/issue/50071 src/fedora/pkgs-sig-rust took 7s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases https://pagure.io/releng/fedora-scm-requests/issue/50072 https://pagure.io/releng/fedora-scm-requests/issue/50073 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wu-diff > - package builds and installs without errors on rawhide
Have you actually checked this or did you only paste my review template?
One of the built packages fails to install with a missing dependency:
Error:
Problem: conflicting requests
- nothing provides (crate(clippy/default) >= 0.0.209 with crate(clippy/default) < 0.0.210~) needed by rust-wu-diff+clippy-devel-0.1.2-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
WARNING: Failed install built packages
i.e. the optional dependency on "clippy" (which is the ancient version of the clippy toolchain component which hasn't been distributed as a separate crate for over four years) needs to be removed
Thanks for catching that! Dependency dropped FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067 FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3 FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |