Bug 2156960 - Review Request: rust-wu-diff - Compute differences between two slices using wu(the O(NP)) algorithm
Summary: Review Request: rust-wu-diff - Compute differences between two slices using w...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ITP-rust-difftastic
TreeView+ depends on / blocked
 
Reported: 2022-12-29 22:42 UTC by Michel Lind
Modified: 2023-01-10 02:17 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-08 01:20:07 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-12-29 22:42:01 UTC
Spec URL: https://salimma.fedorapeople.org/rust-wu-diff.spec
SRPM URL: https://salimma.fedorapeople.org/rust-wu-diff-0.1.2-1.fc37.src.rpm

Description:
Compute differences between two slices using wu(the O(NP)) algorithm.

Fedora Account System Username: salimma

Comment 1 Davide Cavalca 2022-12-30 15:24:05 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 2 Michel Lind 2022-12-30 20:38:20 UTC
Thanks!

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ set -gx C wu-diff

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ set -gx B 2156960

src/fedora/pkgs-sig-rust
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50070

src/fedora/pkgs-sig-rust took 4s
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50071

src/fedora/pkgs-sig-rust took 7s
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50072
https://pagure.io/releng/fedora-scm-requests/issue/50073

Comment 3 Kevin Fenzi 2023-01-01 18:11:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wu-diff

Comment 4 Fabio Valentini 2023-01-01 19:42:33 UTC
> - package builds and installs without errors on rawhide

Have you actually checked this or did you only paste my review template?
One of the built packages fails to install with a missing dependency:

Error: 
 Problem: conflicting requests
  - nothing provides (crate(clippy/default) >= 0.0.209 with crate(clippy/default) < 0.0.210~) needed by rust-wu-diff+clippy-devel-0.1.2-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
WARNING: Failed install built packages


i.e. the optional dependency on "clippy" (which is the ancient version of the clippy toolchain component which hasn't been distributed as a separate crate for over four years) needs to be removed

Comment 5 Michel Lind 2023-01-04 20:40:29 UTC
Thanks for catching that! Dependency dropped

Comment 6 Fedora Update System 2023-01-06 19:21:12 UTC
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

Comment 7 Fedora Update System 2023-01-07 01:28:39 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-01-07 03:11:28 UTC
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

Comment 9 Fedora Update System 2023-01-07 03:12:58 UTC
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

Comment 10 Fedora Update System 2023-01-08 01:20:07 UTC
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-01-08 01:28:47 UTC
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-01-10 02:17:21 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.