Bug 2161164

Summary:	Review Request: python-importlib-resources - Read resources from Python packages
Product:	[Fedora] Fedora	Reporter:	lichaoran <pkwarcraft>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mattia.verga, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2161163

Description lichaoran 2023-01-16 08:05:14 UTC

Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/importlib-resources.spec
SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/python-importlib-resources-5.10.2-1.fc38.src.rpm
Description: used to supported oidc in copr
Fedora Account System Username: lcrpkking

built successfully on copr : https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/

Comment 1 Jakub Kadlčík 2023-01-16 15:30:23 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5238040
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161164-importlib-resources/srpm-builds/05238040/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 lichaoran 2023-02-02 08:18:12 UTC

Spec URL: https://raw.githubusercontent.com/pkking/oidc-in-fedora/main/importlib-resources/importlib-resources.spec
SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/python-importlib-resources-5.10.2-1.fc35.src.rpm

Comment 3 Jakub Kadlčík 2023-02-02 08:21:44 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5404530
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161164-importlib-resources/fedora-rawhide-x86_64/05404530-python-importlib-resources/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 4 Mattia Verga 2023-02-02 17:19:24 UTC

This package is completely useless in Fedora:
"importlib_resources is a backport of Python standard library importlib.resources module for older Pythons."

And for EPEL is already packaged:
https://koji.fedoraproject.org/koji/packageinfo?packageID=30226

Any package requiring importlib.resources should use conditionals in their import like https://github.com/p1c2u/openapi-spec-validator/commit/c4746e3aeea4c762292035751c9e358ed80afae7 so that standard library is used when available.