Bug 2161163 - Review Request: flask-pyoidc - <oidc supported in flask>
Summary: Review Request: flask-pyoidc - <oidc supported in flask>
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On: 2161156 2161164
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-01-16 08:03 UTC by lichaoran
Modified: 2024-03-12 00:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-12 00:45:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description lichaoran 2023-01-16 08:03:30 UTC
Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/flask-pyoidc.spec
SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-flask-pyoidc-3.11.0-1.fc38.src.rpm
Description: oidc supported in flask, to support oidc in copr
Fedora Account System Username: lcrpkking

already built successfully on fc38 on copr: https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/

Comment 1 Jakub Kadlčík 2023-01-16 15:30:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5238039
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161163-flask-pyoidc/srpm-builds/05238039/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Jakub Kadlčík 2023-02-09 14:46:21 UTC
Hello lichaoran,
the Spec URL and SRPM URL return 404.

Comment 5 Package Review 2024-02-10 00:45:29 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Jakub Kadlčík 2024-02-17 11:42:00 UTC
I am really sorry, this ticket somehow slipped through the cracks.

The package fails to build because of missing dependencies 

    No matching package to install: 'python3dist(importlib-resources)'
    No matching package to install: 'python3dist(oic) = 1.4'

Their respective tickets are:

- https://bugzilla.redhat.com/show_bug.cgi?id=2161164
- https://bugzilla.redhat.com/show_bug.cgi?id=2161156

Somebody needs to review them first


> Name:           python-Flask-pyoidc

According to the naming guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming the name should be all lowercase.


> Version:        3.12.1 

There is now 3.14.3, can you please update?

Comment 7 Package Review 2024-03-12 00:45:29 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.