Bug 2161322

Summary: frysk: Use %_fortify_level instead of twiddling with RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Siddhesh Poyarekar <sipoyare>
Component: fryskAssignee: Cagney <cagney>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 39CC: cagney, kasal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-19 17:03:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2158232    

Description Siddhesh Poyarekar 2023-01-16 15:37:37 UTC 
Description of problem:
There is now a canonical way to disable fortification, see "Fortification level" in the build flags guide:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md#source-fortification

This way, one doesn't need to mess with RPM_OPT_FLAGS anymore to do this.
Comment 1 Ben Cotton 2023-02-07 15:05:43 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 2 Fedora Release Engineering 2023-08-16 07:06:29 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.
Comment 3 Cagney 2023-12-19 17:03:04 UTC 
fixed:

@@ -311,9 +311,6 @@ echo '#!/bin/sh -x'			>> configure
 echo 'exec ../$(basename $0) "$@"'	>> configure
 chmod a+x configure
 
-# FIXME: Warnings should be fixed, not suppressed:
-export RPM_OPT_FLAGS=${RPM_OPT_FLAGS/-Wp,-D_FORTIFY_SOURCE=2 /}
-
 %configure \
 	CFLAGS="$RPM_OPT_FLAGS" \
 	CXXFLAGS="$RPM_OPT_FLAGS"