Bug 2161322 - frysk: Use %_fortify_level instead of twiddling with RPM_OPT_FLAGS
Summary: frysk: Use %_fortify_level instead of twiddling with RPM_OPT_FLAGS
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: frysk
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cagney
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2158232
TreeView+ depends on / blocked
 
Reported: 2023-01-16 15:37 UTC by Siddhesh Poyarekar
Modified: 2023-12-19 17:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-19 17:03:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Siddhesh Poyarekar 2023-01-16 15:37:37 UTC
Description of problem:
There is now a canonical way to disable fortification, see "Fortification level" in the build flags guide:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md#source-fortification

This way, one doesn't need to mess with RPM_OPT_FLAGS anymore to do this.

Comment 1 Ben Cotton 2023-02-07 15:05:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Fedora Release Engineering 2023-08-16 07:06:29 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

Comment 3 Cagney 2023-12-19 17:03:04 UTC
fixed:

@@ -311,9 +311,6 @@ echo '#!/bin/sh -x'			>> configure
 echo 'exec ../$(basename $0) "$@"'	>> configure
 chmod a+x configure
 
-# FIXME: Warnings should be fixed, not suppressed:
-export RPM_OPT_FLAGS=${RPM_OPT_FLAGS/-Wp,-D_FORTIFY_SOURCE=2 /}
-
 %configure \
 	CFLAGS="$RPM_OPT_FLAGS" \
 	CXXFLAGS="$RPM_OPT_FLAGS"


Note You need to log in before you can comment on or make changes to this bug.