Bug 2161646
| Summary: | xnec2c: C99 compatibility fix for the configure script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||
| Component: | xnec2c | Assignee: | Florian Weimer <fweimer> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | hobbes1069 | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | xnec2c-4.1.1-6.fc38 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-01-17 13:19:45 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2141798 | ||||||
| Attachments: |
|
||||||
I found the upstream issue tracker at: https://github.com/KJ7LNW/xnec2c/issues That being said I see the patch is at least partly against the generated configure file. Doesn't that get overwritten when autogen.sh is called? (In reply to Richard Shaw from comment #1) > I found the upstream issue tracker at: > https://github.com/KJ7LNW/xnec2c/issues Ah, I missed that the Github link on the 5B4AZ site. I fixed a couple of other packages from the same upstream, and those pages didn't have Github links or any recent changes IIRC. Should I open a PR over there? > That being said I see the patch is at least partly against the generated > configure file. It's also in the Github repository, so that's kind of unavoidable. > Doesn't that get overwritten when autogen.sh is called? Yes, but I didn't change the Fedora build to do that. It makes it easier to minimize the impact of the changes. I'm working on updating to the latest version. Is there a particular compiler flag I can use to see if the problem is already fixed upstream? (In reply to Richard Shaw from comment #3) > I'm working on updating to the latest version. Is there a particular > compiler flag I can use to see if the problem is already fixed upstream? Sorry for the delay in responding, somehow I missed your last Bugzilla update. You can build against the Koji side tag after doing the upstream rebase: https://fedoraproject.org/wiki/Toolchain/PortingToModernC#Special_Koji_side_tag_of_rawhide_with_instrumented_GCC The page has some additional testing options, too. |
Created attachment 1938588 [details] xnec2c-configure-c99.patch A small patch is needed to fix a C99 compatibility issue in the configure script. Filing this here because upstream does not seem to have a bug tracker.