Bug 2161646 - xnec2c: C99 compatibility fix for the configure script
Summary: xnec2c: C99 compatibility fix for the configure script
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xnec2c
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2023-01-17 13:07 UTC by Florian Weimer
Modified: 2023-01-24 15:50 UTC (History)
1 user (show)

Fixed In Version: xnec2c-4.1.1-6.fc38
Clone Of:
Environment:
Last Closed: 2023-01-17 13:19:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
xnec2c-configure-c99.patch (551 bytes, patch)
2023-01-17 13:07 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2023-01-17 13:07:08 UTC
Created attachment 1938588 [details]
xnec2c-configure-c99.patch

A small patch is needed to fix a C99 compatibility issue in the configure script.

Filing this here because upstream does not seem to have a bug tracker.

Comment 1 Richard Shaw 2023-01-18 22:34:25 UTC
I found the upstream issue tracker at:
https://github.com/KJ7LNW/xnec2c/issues

That being said I see the patch is at least partly against the generated configure file.

Doesn't that get overwritten when autogen.sh is called?

Comment 2 Florian Weimer 2023-01-18 22:44:44 UTC
(In reply to Richard Shaw from comment #1)
> I found the upstream issue tracker at:
> https://github.com/KJ7LNW/xnec2c/issues

Ah, I missed that the Github link on the 5B4AZ site. I fixed a couple of other packages from the same upstream, and those pages didn't have Github links or any recent changes IIRC.

Should I open a PR over there?

> That being said I see the patch is at least partly against the generated
> configure file.

It's also in the Github repository, so that's kind of unavoidable.

> Doesn't that get overwritten when autogen.sh is called?

Yes, but I didn't change the Fedora build to do that. It makes it easier to minimize the impact of the changes.

Comment 3 Richard Shaw 2023-01-18 22:48:16 UTC
I'm working on updating to the latest version. Is there a particular compiler flag I can use to see if the problem is already fixed upstream?

Comment 4 Florian Weimer 2023-01-24 15:50:30 UTC
(In reply to Richard Shaw from comment #3)
> I'm working on updating to the latest version. Is there a particular
> compiler flag I can use to see if the problem is already fixed upstream?

Sorry for the delay in responding, somehow I missed your last Bugzilla update.

You can build against the Koji side tag after doing the upstream rebase:

https://fedoraproject.org/wiki/Toolchain/PortingToModernC#Special_Koji_side_tag_of_rawhide_with_instrumented_GCC

The page has some additional testing options, too.


Note You need to log in before you can comment on or make changes to this bug.