Bug 2161997
| Summary: | libinstpatch: Missing declaration of ipatch_init in generate file docs/reference/libinstpatch-scan.c | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | libinstpatch | Assignee: | Ben Beasley <code> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | code, oget.fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-18 16:16:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2137512 | ||
I don’t know, either, but I will look into it. Thanks for the report. This should be fixed with https://src.fedoraproject.org/rpms/libinstpatch/c/0553f9ab54f6b0d4f811f388ea32c80f6f74d2b8?branch=rawhide. I don’t see the warning about this in the normal Rawhide build anymore. Can you please verify that the fix is sufficient in your test environment? Thanks! (In reply to Ben Beasley from comment #2) > This should be fixed with > https://src.fedoraproject.org/rpms/libinstpatch/c/ > 0553f9ab54f6b0d4f811f388ea32c80f6f74d2b8?branch=rawhide. I don’t see the > warning about this in the normal Rawhide build anymore. > > Can you please verify that the fix is sufficient in your test environment? > Thanks! Thank you so much, this fixes my tester as well. Do you have an upstream reference for this fix? (In reply to Florian Weimer from comment #3) > Thank you so much, this fixes my tester as well. > > Do you have an upstream reference for this fix? Yes, I sent a PR upstream, https://github.com/swami/libinstpatch/pull/71, and included a link in a spec file comment above the patch. Relevant discussion is also in https://github.com/swami/libinstpatch/issues/65, linked from the PR. |
libinstpatch-scan.c contains this: int main (void) { ipatch_init(); … The call probably ends up there because gtk-doc is called with “--type-init-func=ipatch_init()”. The function is declared in the installed libinstpatch/misc.h header file, but that file isn't include here. How can we fix this? Unfortunately I do not know gtk-doc works. We could build the whole package in C89 mode, but that seems excessive.