Bug 2161997 - libinstpatch: Missing declaration of ipatch_init in generate file docs/reference/libinstpatch-scan.c
Summary: libinstpatch: Missing declaration of ipatch_init in generate file docs/refere...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libinstpatch
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2023-01-18 14:29 UTC by Florian Weimer
Modified: 2023-01-18 16:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-01-18 16:16:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2023-01-18 14:29:01 UTC
libinstpatch-scan.c contains this:

int
main (void)
{
  ipatch_init();
…

The call probably ends up there because gtk-doc is called with “--type-init-func=ipatch_init()”. The function is declared in the installed libinstpatch/misc.h header file, but that file isn't include here.

How can we fix this? Unfortunately I do not know gtk-doc works.

We could build the whole package in C89 mode, but that seems excessive.

Comment 1 Ben Beasley 2023-01-18 14:36:15 UTC
I don’t know, either, but I will look into it. Thanks for the report.

Comment 2 Ben Beasley 2023-01-18 15:50:35 UTC
This should be fixed with https://src.fedoraproject.org/rpms/libinstpatch/c/0553f9ab54f6b0d4f811f388ea32c80f6f74d2b8?branch=rawhide. I don’t see the warning about this in the normal Rawhide build anymore.

Can you please verify that the fix is sufficient in your test environment? Thanks!

Comment 3 Florian Weimer 2023-01-18 15:57:55 UTC
(In reply to Ben Beasley from comment #2)
> This should be fixed with
> https://src.fedoraproject.org/rpms/libinstpatch/c/
> 0553f9ab54f6b0d4f811f388ea32c80f6f74d2b8?branch=rawhide. I don’t see the
> warning about this in the normal Rawhide build anymore.
> 
> Can you please verify that the fix is sufficient in your test environment?
> Thanks!

Thank you so much, this fixes my tester as well.

Do you have an upstream reference for this fix?

Comment 4 Ben Beasley 2023-01-18 16:16:30 UTC
(In reply to Florian Weimer from comment #3)
> Thank you so much, this fixes my tester as well.
> 
> Do you have an upstream reference for this fix?

Yes, I sent a PR upstream, https://github.com/swami/libinstpatch/pull/71, and included a link in a spec file comment above the patch.

Relevant discussion is also in https://github.com/swami/libinstpatch/issues/65, linked from the PR.


Note You need to log in before you can comment on or make changes to this bug.