Bug 2168599
| Summary: | bnxt_en: revert 778c3af371b3 ("ethernet: Remove vf rate limit check for drivers") | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Ken Cox <jkc> |
| Component: | kernel | Assignee: | Ken Cox <jkc> |
| kernel sub component: | NIC Drivers | QA Contact: | Dipali <dipatel> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | unspecified | CC: | dipatel, network-qe |
| Version: | 9.2 | Keywords: | Triaged |
| Target Milestone: | rc | Flags: | dipatel:
needinfo+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-5.14.0-281.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-09 08:13:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
@dipatel Please review and set ITM. Thanks! Pre-verified kernel 5.14.0-264.2036_772816223.el9 Tests Verified: 1.sanity check to test basic functions for nic driver (broadcast,multicast,ip,mtu,para santy,mac,promisc,selftest,dev) 2.packet statistics test which includes "receive bytes","send bytes"&"multicast" statistics 3.link check test 4.test ring buffer modification for nic 5.Test offload for nic driver 6.test multituque function for nic 7.scaling test for nic, including rps, xps, rss, tx_maxrate 8.stress testing for nic driver 9.Test abnormal conditions for nic driver 10.vlan geneve & vlan vxlan test 11.specific test 12.nic performance test 13.topo reboot test to set up topo, reboot and check basic communication and dmesg 14.devlink test 15.Regular_netperf test 16.ethtool coalesce sanity test 17.ethtool pause test 18.hashkey setting by ethtool(valid,invaid) 19.Regression tests for bugs related to ethtool 20.Test ethtool perform basic operations 21.nic driver load test 22.devlink selftest Related Jobs: https://beaker.engineering.redhat.com/jobs/7528056 https://beaker.engineering.redhat.com/jobs/7528102 https://beaker.engineering.redhat.com/jobs/7529554 https://beaker.engineering.redhat.com/jobs/7528669 Verified kernel-5.14.0-281.el9 Tests Verified: 1.ethtool offload test 2.scaling test for nic, including rps, xps, rss, tx_maxrate 3.stress testing for nic driver 4.Test abnormal conditions for nic driver 5.specific test 6.nic performance test 7.topo reboot test to set up topo, reboot and check basic communication and dmesg 8.wol test 9.devlink test 10.netperf stress test 11.devlink self test Related Jobs: https://beaker.engineering.redhat.com/jobs/7565155 https://beaker.engineering.redhat.com/jobs/7563930 https://beaker.engineering.redhat.com/jobs/7562878 https://beaker.engineering.redhat.com/jobs/7562878 Verified kernel-5.14.0-281.el9 Tests Verified: 1.ethtool offload test 2.scaling test for nic, including rps, xps, rss, tx_maxrate 3.stress testing for nic driver 4.Test abnormal conditions for nic driver 5.specific test 6.nic performance test 7.topo reboot test to set up topo, reboot and check basic communication and dmesg 8.wol test 9.devlink test 10.netperf stress test 11.devlink self test Related Jobs: https://beaker.engineering.redhat.com/jobs/7565155 https://beaker.engineering.redhat.com/jobs/7563930 https://beaker.engineering.redhat.com/jobs/7562878 https://beaker.engineering.redhat.com/jobs/7562878 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:2458 |
Commit 778c3af371b3 ("ethernet: Remove vf rate limit check for drivers") was backported for RHEL9.2 but it has a dependency on upstream commit a14857c27a50 ("rtnetlink: verify rate parameters for calls to ndo_set_vf_rate") which has not been backported to RHEL9 at this time. Normally, the 'ip' command is used to set the min and max rate, but the 'ip' command checks this condition before sending to the kernel, so this can't be reproduced using the 'ip' command. However, any other program that sends a request to the kernel to change the rate via IFLA_VF_RATE could potentially pass in invalid parameters that would not get flagged by the kernel as being invalid.