RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2168599 - bnxt_en: revert 778c3af371b3 ("ethernet: Remove vf rate limit check for drivers")
Summary: bnxt_en: revert 778c3af371b3 ("ethernet: Remove vf rate limit check for drive...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: kernel
Version: 9.2
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Ken Cox
QA Contact: Dipali
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-09 13:56 UTC by Ken Cox
Modified: 2023-05-09 10:13 UTC (History)
2 users (show)

Fixed In Version: kernel-5.14.0-281.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-09 08:13:38 UTC
Type: ---
Target Upstream Version:
Embargoed:
dipatel: needinfo+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab redhat/centos-stream/src/kernel centos-stream-9 merge_requests 2036 0 None opened Revert "ethernet: Remove vf rate limit check for drivers" 2023-02-09 15:54:32 UTC
Red Hat Issue Tracker RHELPLAN-148166 0 None None None 2023-02-09 13:58:06 UTC
Red Hat Product Errata RHSA-2023:2458 0 None None None 2023-05-09 08:13:53 UTC

Description Ken Cox 2023-02-09 13:56:59 UTC 
Commit 778c3af371b3 ("ethernet: Remove vf rate limit check for drivers") was backported for RHEL9.2 but it has a dependency on upstream commit a14857c27a50 ("rtnetlink: verify rate parameters for calls to ndo_set_vf_rate") which has not been backported to RHEL9 at this time.


Normally, the 'ip' command is used to set the min and max rate, but the 'ip' command checks this condition before sending to the kernel, so this can't be reproduced using the 'ip' command.

However, any other program that sends a request to the kernel to change the rate via IFLA_VF_RATE could potentially pass in invalid parameters that would not get flagged by the kernel as being invalid.
Comment 2 Ken Cox 2023-02-13 12:12:45 UTC 
@dipatel 
Please review and set ITM.

Thanks!
Comment 3 Dipali 2023-02-17 20:12:07 UTC 
Pre-verified kernel 5.14.0-264.2036_772816223.el9

Tests Verified:
1.sanity check to test basic functions for nic driver (broadcast,multicast,ip,mtu,para santy,mac,promisc,selftest,dev)
2.packet statistics test which includes "receive bytes","send bytes"&"multicast" statistics
3.link check test
4.test ring buffer modification for nic
5.Test offload for nic driver
6.test multituque function for nic
7.scaling test for nic, including rps, xps, rss, tx_maxrate
8.stress testing for nic driver
9.Test abnormal conditions for nic driver
10.vlan geneve & vlan vxlan test
11.specific test
12.nic performance test
13.topo reboot test to set up topo, reboot and check basic communication and dmesg
14.devlink test
15.Regular_netperf test
16.ethtool coalesce sanity test
17.ethtool pause test
18.hashkey setting by ethtool(valid,invaid)
19.Regression tests for bugs related to ethtool
20.Test ethtool perform basic operations
21.nic driver load test
22.devlink selftest

Related Jobs:
https://beaker.engineering.redhat.com/jobs/7528056
https://beaker.engineering.redhat.com/jobs/7528102
https://beaker.engineering.redhat.com/jobs/7529554
https://beaker.engineering.redhat.com/jobs/7528669
Comment 7 Dipali 2023-02-27 18:59:45 UTC 
Verified kernel-5.14.0-281.el9
Tests Verified:
1.ethtool offload test
2.scaling test for nic, including rps, xps, rss, tx_maxrate
3.stress testing for nic driver
4.Test abnormal conditions for nic driver
5.specific test
6.nic performance test
7.topo reboot test to set up topo, reboot and check basic communication and dmesg
8.wol test
9.devlink test
10.netperf stress test
11.devlink self test

Related Jobs:
https://beaker.engineering.redhat.com/jobs/7565155
https://beaker.engineering.redhat.com/jobs/7563930
https://beaker.engineering.redhat.com/jobs/7562878
https://beaker.engineering.redhat.com/jobs/7562878
Comment 8 Dipali 2023-02-27 19:00:23 UTC 
Verified kernel-5.14.0-281.el9
Tests Verified:
1.ethtool offload test
2.scaling test for nic, including rps, xps, rss, tx_maxrate
3.stress testing for nic driver
4.Test abnormal conditions for nic driver
5.specific test
6.nic performance test
7.topo reboot test to set up topo, reboot and check basic communication and dmesg
8.wol test
9.devlink test
10.netperf stress test
11.devlink self test

Related Jobs:
https://beaker.engineering.redhat.com/jobs/7565155
https://beaker.engineering.redhat.com/jobs/7563930
https://beaker.engineering.redhat.com/jobs/7562878
https://beaker.engineering.redhat.com/jobs/7562878
Comment 10 errata-xmlrpc 2023-05-09 08:13:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2458
Note You need to log in before you can comment on or make changes to this bug.