Bug 2168973
| Summary: | Review Request: rust-time-core - Internal implementation details of the 'time' crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | blinxen <h-k-81> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | h-k-81, package-review |
| Target Milestone: | --- | Flags: | h-k-81:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/time-core | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-02-20 01:36:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2137245 | ||
|
Description
Fabio Valentini
2023-02-10 19:40:20 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5516510 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168973-rust-time-core/fedora-rawhide-x86_64/05516510-rust-time-core/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is my first formal review. But because the spec file was generated with rust2rpm, the review should pretty straightforward. Review: - The generated "review.txt" file did not contain any issues - The package can be built and installed in rawhide without issues - License files are present and referenced via %license macro - Latest version is packaged - Package complies with the rust packaging guidelines In the scratch build, the s390x [1] build did not go off. But this was probably due to the planned outage of the s390x builders. Package APPROVED. [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=97351449 Awesome, thanks for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-core Built for rawhide and Fedora 38: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ad8ddc2df https://bodhi.fedoraproject.org/updates/FEDORA-2023-d88b274901 |