Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://decathorpe.fedorapeople.org/rust-time-core.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-time-core-0.1.0-1.fc37.src.rpm Description: Internal implementation details of the 'time' crate. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=97351384
Copr build: https://copr.fedorainfracloud.org/coprs/build/5516510 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168973-rust-time-core/fedora-rawhide-x86_64/05516510-rust-time-core/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is my first formal review. But because the spec file was generated with rust2rpm, the review should pretty straightforward. Review: - The generated "review.txt" file did not contain any issues - The package can be built and installed in rawhide without issues - License files are present and referenced via %license macro - Latest version is packaged - Package complies with the rust packaging guidelines In the scratch build, the s390x [1] build did not go off. But this was probably due to the planned outage of the s390x builders. Package APPROVED. [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=97351449
Awesome, thanks for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-core
Built for rawhide and Fedora 38: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ad8ddc2df https://bodhi.fedoraproject.org/updates/FEDORA-2023-d88b274901