Bug 2169529
| Summary: | Review Request: python-slack-sdk - Python Slack SDK | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ondrej Mosnáček <omosnacek> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | code, package-review, troy |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://slack.dev/python-slack-sdk/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-02-28 14:24:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ondrej Mosnáček
2023-02-13 21:30:48 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5523491 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169529-python-slack-sdk/fedora-rawhide-x86_64/05523491-python-slack-sdk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Is this library targeted as a dependency of another package? I know that generally for development the recommendation is to not use system installed packages, so there might not a lot of users of this package unless there is already some package that you have in mind. (In reply to Troy Curtis from comment #2) > Is this library targeted as a dependency of another package? No, it's not. > I know that > generally for development the recommendation is to not use system installed > packages, so there might not a lot of users of this package unless there is > already some package that you have in mind. Is that recommendation officially stated anywhere? I remembered this thread [1], which lists several pros of having Python packages in Fedora (many applicable even to leaf libraries). Personally, I prefer to consume Python libraries from Fedora repos for my scripting needs, since it's easier to keep the packages up to date and I also don't need to install them again when I upgrade Fedora and the system Python version is bumped. I plan to use this package for personal/work use (porting an existing IRC bot to Slack), so there will be at least one user :) Even if I were the only user, I don't see any harm in the package being in Fedora, as long as it's properly maintained. [1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/33YRLXPBUHVFS3OIPNEMEOTNMV7MQALE/ There is no policy against having pure-Python library leaf packages in Fedora. Most people package pure-Python libraries as dependencies for applications, but if they are valuable to you, you are free to package them. In this case, I think this is already packaged as part of https://src.fedoraproject.org/rpms/python-slackclient. That package should add: %py_provides python3-slack %py_provides python3-slack-sdk based on https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules. Oh, indeed python-slackclient is the same package. It even provides python3dist(slack-sdk), which I should have repoqueried first... Closing this review request. |