Bug 2169529 - Review Request: python-slack-sdk - Python Slack SDK
Summary: Review Request: python-slack-sdk - Python Slack SDK
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://slack.dev/python-slack-sdk/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-13 21:30 UTC by Ondrej Mosnáček
Modified: 2023-02-28 14:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-02-28 14:24:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ondrej Mosnáček 2023-02-13 21:30:48 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/omos/python-slack-sdk/fedora-rawhide-x86_64/05519691-python-slack-sdk/python-slack-sdk.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/omos/python-slack-sdk/fedora-rawhide-x86_64/05519691-python-slack-sdk/python-slack-sdk-3.19.5-1.fc39.src.rpm
Description:
  The Slack platform offers several APIs to build apps. Each Slack API delivers
  part of the capabilities from the platform, so that you can pick just those
  that fit for your needs. This SDK offers a corresponding package for each of
  Slack’s APIs. They are small and powerful when used independently, and work
  seamlessly when used together, too.
Fedora Account System Username: omos

COPR build: https://copr.fedorainfracloud.org/coprs/omos/python-slack-sdk/build/5519691/

Comment 1 Jakub Kadlčík 2023-02-13 21:37:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5523491
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169529-python-slack-sdk/fedora-rawhide-x86_64/05523491-python-slack-sdk/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Troy Curtis 2023-02-25 01:10:37 UTC
Is this library targeted as a dependency of another package? I know that generally for development the recommendation is to not use system installed packages, so there might not a lot of users of this package unless there is already some package that you have in mind.

Comment 3 Ondrej Mosnáček 2023-02-26 19:22:32 UTC
(In reply to Troy Curtis from comment #2)
> Is this library targeted as a dependency of another package?

No, it's not.

> I know that
> generally for development the recommendation is to not use system installed
> packages, so there might not a lot of users of this package unless there is
> already some package that you have in mind.

Is that recommendation officially stated anywhere? I remembered this thread [1], which lists several pros of having Python packages in Fedora (many applicable even to leaf libraries). Personally, I prefer to consume Python libraries from Fedora repos for my scripting needs, since it's easier to keep the packages up to date and I also don't need to install them again when I upgrade Fedora and the system Python version is bumped.

I plan to use this package for personal/work use (porting an existing IRC bot to Slack), so there will be at least one user :) Even if I were the only user, I don't see any harm in the package being in Fedora, as long as it's properly maintained.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/33YRLXPBUHVFS3OIPNEMEOTNMV7MQALE/

Comment 4 Ben Beasley 2023-02-28 13:25:27 UTC
There is no policy against having pure-Python library leaf packages in Fedora. Most people package pure-Python libraries as dependencies for applications, but if they are valuable to you, you are free to package them.

In this case, I think this is already packaged as part of https://src.fedoraproject.org/rpms/python-slackclient. That package should add:

  %py_provides python3-slack
  %py_provides python3-slack-sdk

based on https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules.

Comment 6 Ondrej Mosnáček 2023-02-28 14:24:41 UTC
Oh, indeed python-slackclient is the same package. It even provides python3dist(slack-sdk), which I should have repoqueried first... Closing this review request.


Note You need to log in before you can comment on or make changes to this bug.