Bug 217249 (atomorun)

Summary:	Review Request: atomorun - Jump&Run game where you have to flee an exploding nuclear bomb
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Christopher Stone <chris.stone>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mr.ecik
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-26 18:51:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Hans de Goede 2006-11-25 21:17:27 UTC

Spec URL: http://people.atrpms.net/~hdegoede/atomorun.spec
SRPM URL: http://people.atrpms.net/~hdegoede/atomorun-1.1-0.1.pre2.fc7.src.rpm
Description:
Atomorun is a OpenGL Jump&Run game where you have to flee an exploding
nuclear bomb.

Comment 1 Christopher Stone 2006-11-25 21:53:50 UTC

==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license included in %doc
- spec written in American english
- spec legible
- sources match upstream
41522a330c0da7c6e79c46baa2c1d8c3  atomorun-1.1_pre2.tar.gz
- package successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
X package uses a directory which is not pulled in from Requires
- no duplicates in %files
- file permissions set properly
- spec contains proper %clean section
- macro usage is consistent
- package contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- GUI app contains proper .desktop file
- package does not own files or directories owned by other packages


==== MUST FIX ====
- Add Requires: icons-hicolor-theme to pull in icons directory

Comment 2 Michał Bentkowski 2006-11-25 22:01:42 UTC

(In reply to comment #1)
> ==== MUST FIX ====
> - Add Requires: icons-hicolor-theme to pull in icons directory
> 

Shouldn't it be hicolor-icon-theme? ;)

Comment 3 Christopher Stone 2006-11-25 22:02:12 UTC

> Shouldn't it be hicolor-icon-theme? ;)

ya probably :)

Comment 4 Hans de Goede 2006-11-26 07:18:43 UTC

(In reply to comment #1)
> ==== MUST FIX ====
> - Add Requires: icons-hicolor-theme to pull in icons directory
> 

/me stupid, doh

New version with this fixed here:
Spec URL: http://people.atrpms.net/~hdegoede/atomorun.spec
SRPM URL: http://people.atrpms.net/~hdegoede/atomorun-1.1-0.2.pre2.fc7.src.rpm

Comment 5 Christopher Stone 2006-11-26 12:36:00 UTC

All MUST items fixed, APPROVED.

Comment 6 Hans de Goede 2006-11-26 18:51:37 UTC

Thanks, imported and building as we speak, closing.