Spec URL: http://people.atrpms.net/~hdegoede/atomorun.spec SRPM URL: http://people.atrpms.net/~hdegoede/atomorun-1.1-0.1.pre2.fc7.src.rpm Description: Atomorun is a OpenGL Jump&Run game where you have to flee an exploding nuclear bomb.
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - license included in %doc - spec written in American english - spec legible - sources match upstream 41522a330c0da7c6e79c46baa2c1d8c3 atomorun-1.1_pre2.tar.gz - package successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses a directory which is not pulled in from Requires - no duplicates in %files - file permissions set properly - spec contains proper %clean section - macro usage is consistent - package contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - GUI app contains proper .desktop file - package does not own files or directories owned by other packages ==== MUST FIX ==== - Add Requires: icons-hicolor-theme to pull in icons directory
(In reply to comment #1) > ==== MUST FIX ==== > - Add Requires: icons-hicolor-theme to pull in icons directory > Shouldn't it be hicolor-icon-theme? ;)
> Shouldn't it be hicolor-icon-theme? ;) ya probably :)
(In reply to comment #1) > ==== MUST FIX ==== > - Add Requires: icons-hicolor-theme to pull in icons directory > /me stupid, doh New version with this fixed here: Spec URL: http://people.atrpms.net/~hdegoede/atomorun.spec SRPM URL: http://people.atrpms.net/~hdegoede/atomorun-1.1-0.2.pre2.fc7.src.rpm
All MUST items fixed, APPROVED.
Thanks, imported and building as we speak, closing.