Bug 2173716
| Summary: | Review Request: rust-test-case-macros - Procedural macro attribute for generating parametrized test cases | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/test-case-macros | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-03 15:27:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2027038 | ||
|
Description
Fabio Valentini
2023-02-27 18:04:06 UTC
Note: I am packaging v2.2.2 and not v3.0.0 on purpose. The package I'm working on (fd-find) requires test-case v2, which requires test-case-macros v2. Copr build: https://copr.fedorainfracloud.org/coprs/build/5574395 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173716-rust-test-case-macros/fedora-rawhide-x86_64/05574395-rust-test-case-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches (In reply to Michel Alexandre Salim from comment #3) > - latest version of the crate is packaged ^ not latest, but there's an explanation Thanks for the review! :) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-test-case-macros Imported, built, and submitted: https://bodhi.fedoraproject.org/updates/FEDORA-2023-617e48c47d https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa61180662 https://bodhi.fedoraproject.org/updates/FEDORA-2023-17198904f9 https://bodhi.fedoraproject.org/updates/FEDORA-2023-2258507395 Thanks everybody! |