Bug 2173716 - Review Request: rust-test-case-macros - Procedural macro attribute for generating parametrized test cases
Summary: Review Request: rust-test-case-macros - Procedural macro attribute for genera...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/test-case-ma...
Whiteboard:
Depends On:
Blocks: 2027038
TreeView+ depends on / blocked
 
Reported: 2023-02-27 18:04 UTC by Fabio Valentini
Modified: 2023-03-03 15:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-03-03 15:27:08 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-02-27 18:04:06 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-test-case-macros.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-test-case-macros-2.2.2-1.fc37.src.rpm

Description:
Provides #[test_case(...)] procedural macro attribute for generating
parametrized test cases easily.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-02-27 18:04:58 UTC
Note: I am packaging v2.2.2 and not v3.0.0 on purpose.
The package I'm working on (fd-find) requires test-case v2, which requires test-case-macros v2.

Comment 2 Jakub Kadlčík 2023-02-27 18:13:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5574395
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173716-rust-test-case-macros/fedora-rawhide-x86_64/05574395-rust-test-case-macros/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2023-03-02 19:36:41 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Michel Lind 2023-03-02 19:37:17 UTC
(In reply to Michel Alexandre Salim from comment #3)
> - latest version of the crate is packaged
^ not latest, but there's an explanation

Comment 5 Fabio Valentini 2023-03-02 21:19:07 UTC
Thanks for the review! :)

Comment 6 Fedora Admin user for bugzilla script actions 2023-03-02 21:20:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-test-case-macros


Note You need to log in before you can comment on or make changes to this bug.