Bug 2174116 (review-rust-nom-supreme)

Summary: Review Request: rust-nom-supreme - Collection of excellent utilities for nom
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/nom-supreme
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-25 00:49:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2174100, 2174113, 2174114, 2174115    
Bug Blocks: 2174146    

Description Michel Lind 2023-02-28 17:32:26 UTC
Spec URL: https://salimma.fedorapeople.org/rust-nom-supreme.spec
SRPM URL: https://salimma.fedorapeople.org/rust-nom-supreme-0.8.0-1.fc37.src.rpm

Description:
A collection of excellent utilities for nom.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-28 17:41:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5579995
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174116-rust-nom-supreme/fedora-rawhide-x86_64/05579995-rust-nom-supreme/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-06-12 19:23:06 UTC
This package fails to build due to a missing dependency:
https://bugzilla.redhat.com/show_bug.cgi?id=2174114

Comment 3 Fabio Valentini 2023-06-15 17:47:47 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-06-15 18:12:20 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nom-supreme

Comment 5 Fabio Valentini 2023-06-15 19:41:57 UTC
I just noticed these rpmlint warnings:

rust-nom-supreme-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/nom-supreme-0.8.0/CHANGELOG.md
rust-nom-supreme-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/nom-supreme-0.8.0/README.md

These are cosmetic only, but they would be easy to fix.

Comment 6 Fedora Update System 2023-06-16 02:25:58 UTC
FEDORA-2023-43512b4d4f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

Comment 7 Fedora Update System 2023-06-16 02:49:25 UTC
FEDORA-2023-5187dc9252 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

Comment 8 Fedora Update System 2023-06-16 02:59:46 UTC
FEDORA-EPEL-2023-49aa6f1164 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

Comment 9 Fedora Update System 2023-06-17 01:41:26 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-43512b4d4f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-06-17 02:00:50 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-06-17 02:42:54 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5187dc9252 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-06-25 00:49:51 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-06-25 00:53:57 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-06-25 01:26:03 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.