Spec URL: https://salimma.fedorapeople.org/rust-joinery2.spec SRPM URL: https://salimma.fedorapeople.org/rust-joinery2-2.1.0-1.fc37.src.rpm Description: A small crate for generically joining iterators with a separator. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/5579979 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174100-rust-joinery2/fedora-rawhide-x86_64/05579979-rust-joinery2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review General comments: - Package was generated with rust2rpm and no modifications were done - joinery is already packaged for fedora. This is probably a compat package that is required for building nushell :D ? Issues: - Some files have incorrect end-of-line encoding, see rpmlint Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 11 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/rust-joinery2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- joinery2-devel , rust-joinery2+default-devel , rust-joinery2+nightly- devel , rust-joinery2+proc-macro2-devel , rust-joinery2+quote-devel , rust-joinery2+syn-devel , rust-joinery2+token-stream-devel [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rust-joinery2-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+default-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+nightly-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+proc-macro2-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+quote-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+syn-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2+token-stream-devel-2.1.0-1.fc39.noarch.rpm rust-joinery2-2.1.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5p2eaevf')] checks: 31, packages: 8 rust-joinery2-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/src/lib.rs rust-joinery2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/CHANGELOG.md rust-joinery2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/README.md rust-joinery2+default-devel.noarch: W: no-documentation rust-joinery2+nightly-devel.noarch: W: no-documentation rust-joinery2+proc-macro2-devel.noarch: W: no-documentation rust-joinery2+quote-devel.noarch: W: no-documentation rust-joinery2+syn-devel.noarch: W: no-documentation rust-joinery2+token-stream-devel.noarch: W: no-documentation 8 packages and 0 specfiles checked; 1 errors, 8 warnings, 1 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 7 rust-joinery2-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/src/lib.rs rust-joinery2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/CHANGELOG.md rust-joinery2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/joinery-2.1.0/README.md rust-joinery2+default-devel.noarch: W: no-documentation rust-joinery2+nightly-devel.noarch: W: no-documentation rust-joinery2+proc-macro2-devel.noarch: W: no-documentation rust-joinery2+quote-devel.noarch: W: no-documentation rust-joinery2+token-stream-devel.noarch: W: no-documentation rust-joinery2+syn-devel.noarch: W: no-documentation 7 packages and 0 specfiles checked; 1 errors, 8 warnings, 1 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/joinery/2.1.0/download#/joinery-2.1.0.crate : CHECKSUM(SHA256) this package : 72167d68f5fce3b8655487b8038691a3c9984ee769590f93f2a631f4ad64e4f5 CHECKSUM(SHA256) upstream package : 72167d68f5fce3b8655487b8038691a3c9984ee769590f93f2a631f4ad64e4f5 Requires -------- rust-joinery2-devel (rpmlib, GLIBC filtered): cargo rust-joinery2+default-devel (rpmlib, GLIBC filtered): cargo crate(joinery) rust-joinery2+nightly-devel (rpmlib, GLIBC filtered): cargo crate(joinery) rust-joinery2+proc-macro2-devel (rpmlib, GLIBC filtered): (crate(proc-macro2) >= 1.0.27 with crate(proc-macro2) < 2.0.0~) cargo crate(joinery) rust-joinery2+quote-devel (rpmlib, GLIBC filtered): (crate(quote) >= 1.0.9 with crate(quote) < 2.0.0~) cargo crate(joinery) rust-joinery2+syn-devel (rpmlib, GLIBC filtered): (crate(syn) >= 1.0.72 with crate(syn) < 2.0.0~) (crate(syn/printing) >= 1.0.72 with crate(syn/printing) < 2.0.0~) cargo crate(joinery) rust-joinery2+token-stream-devel (rpmlib, GLIBC filtered): cargo crate(joinery) crate(joinery/proc-macro2) crate(joinery/quote) crate(joinery/syn) Provides -------- rust-joinery2-devel: crate(joinery) rust-joinery2-devel rust-joinery2+default-devel: crate(joinery/default) rust-joinery2+default-devel rust-joinery2+nightly-devel: crate(joinery/nightly) rust-joinery2+nightly-devel rust-joinery2+proc-macro2-devel: crate(joinery/proc-macro2) rust-joinery2+proc-macro2-devel rust-joinery2+quote-devel: crate(joinery/quote) rust-joinery2+quote-devel rust-joinery2+syn-devel: crate(joinery/syn) rust-joinery2+syn-devel rust-joinery2+token-stream-devel: crate(joinery/token-stream) rust-joinery2+token-stream-devel Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-joinery2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, C/C++, Ocaml, R, Python, Haskell, Perl, Java, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to blinxen from comment #2) > Taking this review > > General comments: > > - Package was generated with rust2rpm and no modifications were done > - joinery is already packaged for fedora. This is probably a compat package > that is required for building nushell :D ? > > Issues: > > - Some files have incorrect end-of-line encoding, see rpmlint > Sorry for the delay! Yes, this is a compat crate so does not even really require a review now, but reviews always help surface these nits. Will get them fixed soon.
Fixed rpmlint EOL warnings Spec URL: https://salimma.fedorapeople.org/rust-joinery2.spec SRPM URL: https://salimma.fedorapeople.org/rust-joinery2-2.1.0-1.fc37.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5987348 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174100-rust-joinery2/fedora-rawhide-x86_64/05987348-rust-joinery2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
EOL warnings / error are still present, see the the new `review.txt`. I will accept this nonetheless because it is a compat package. I hope this is not wrong :D.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-joinery2
FEDORA-EPEL-2023-aa405df692 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-aa405df692
FEDORA-2023-f4c084a956 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f4c084a956
FEDORA-2023-49aa745e4d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-49aa745e4d
FEDORA-2023-f4c084a956 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f4c084a956 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f4c084a956 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-aa405df692 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-aa405df692 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-49aa745e4d has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-49aa745e4d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-49aa745e4d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-f4c084a956 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-aa405df692 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-49aa745e4d has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.