Bug 2175192

Summary: python-crochet fails to build with Python 3.12: AttributeError: module 'configparser' has no attribute 'SafeConfigParser'.
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-crochetAssignee: Aurelien Bompard <aurelien>
Status: ON_QA --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 39CC: aurelien, mattia.verga, mhroncok, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-crochet-1.12.0-3.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2135404    

Description Tomáš Hrnčiar 2023-03-03 14:04:18 UTC
python-crochet fails to build with Python 3.12.0a5.

Traceback (most recent call last):
  File "/builddir/build/BUILD/crochet-1.10.0/setup.py", line 32, in <module>
    version=versioneer.get_version(),
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/crochet-1.10.0/versioneer.py", line 1473, in get_version
    return get_versions()["version"]
           ^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/crochet-1.10.0/versioneer.py", line 1406, in get_versions
    cfg = get_config_from_root(root)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/crochet-1.10.0/versioneer.py", line 412, in get_config_from_root
    parser = configparser.SafeConfigParser()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

Several names deprecated in the configparser way back in 3.2 have been removed
per gh-89336:

    - configparser.ParsingError no longer has a filename attribute or argument.
Use the source attribute and argument instead.

    - configparser no longer has a SafeConfigParser class. Use the shorter
ConfigParser name instead.

    - configparser.ConfigParser no longer has a readfp method. Use read_file()
instead.

https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05583032-python-crochet/

For all our attempts to build python-crochet with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-crochet/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Mattia Verga 2023-07-04 18:51:56 UTC
Despite a successful build in f39-python sidetag, the package is broken due to a really old version packaged in Fedora. (it still 'import imp' which was removed in python 3.12)

Not sure why tests run during build have not highlighted this, but for example python-robosignatory tests shows that.

Comment 2 Miro Hrončok 2023-07-04 19:58:02 UTC
https://src.fedoraproject.org/rpms/python-crochet/c/4e63bdda3f94907dee49dd48528982dcb643786e?branch=rawhide

This added:

  BuildRequires:  python3-zombie-imp

Apparently, the dependency is also needed on runtime.

Comment 3 Miro Hrončok 2023-07-04 20:13:38 UTC
Like this: https://src.fedoraproject.org/rpms/python-crochet/pull-request/3

Comment 4 Miro Hrončok 2023-07-04 22:22:49 UTC
Should be fixed in python-crochet-1.12.0-3.fc39

Comment 5 Fedora Release Engineering 2023-08-16 07:10:46 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.