Bug 2176670
| Summary: | Review Request: fedora-iot-config - ostree configuration file for Fedora IoT | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Whalen <pwhalen> |
| Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | miabbott, package-review, pbrobinson |
| Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://fedoraproject.org/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-19 01:38:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Whalen
2023-03-08 22:10:42 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5616167 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176670-fedora-iot-config/fedora-rawhide-x86_64/05616167-fedora-iot-config/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This looks mostly fine, just one small piece:
install -d %{buildroot}%{_sysconfdir}/ostree/remotes.d/
%dir %{_sysconfdir}/ostree/remotes.d
That directory shouldn't need to be created as it's owned/created by the ostree-libs package so we should just add that as a BuildReq so it's there during build, and a Requires.
That can be fixed before commit, other than that this is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-iot-config FEDORA-2023-8dcfdd9e10 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10 FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |