Bug 2176670 - Review Request: fedora-iot-config - ostree configuration file for Fedora IoT
Summary: Review Request: fedora-iot-config - ostree configuration file for Fedora IoT
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://fedoraproject.org/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-08 22:10 UTC by Paul Whalen
Modified: 2023-04-19 01:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-19 01:38:48 UTC
Type: Bug
Embargoed:
pbrobinson: fedora-review+


Attachments (Terms of Use)

Comment 1 Jakub Kadlčík 2023-03-08 22:16:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5616167
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2176670-fedora-iot-config/fedora-rawhide-x86_64/05616167-fedora-iot-config/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Peter Robinson 2023-03-29 21:20:36 UTC
This looks mostly fine, just one small piece:

install -d %{buildroot}%{_sysconfdir}/ostree/remotes.d/

%dir %{_sysconfdir}/ostree/remotes.d

That directory shouldn't need to be created as it's owned/created by the ostree-libs package so we should just add that as a BuildReq so it's there during build, and a Requires.

That can be fixed before commit, other than that this is APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-04-04 13:45:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-iot-config

Comment 4 Fedora Update System 2023-04-11 15:13:29 UTC
FEDORA-2023-8dcfdd9e10 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10

Comment 5 Fedora Update System 2023-04-11 22:14:54 UTC
FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-04-19 01:38:48 UTC
FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.