Bug 2177213

Summary: Multiple grub2 binaries are not compiled with annobin plugin enabled
Product: Red Hat Enterprise Linux 9 Reporter: Matus Marhefka <mmarhefk>
Component: grub2Assignee: Bootloader engineering team <bootloader-eng-team>
Status: CLOSED MIGRATED QA Contact: Release Test Team <release-test-team-automation>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.2CC: jpazdziora, mlewando, raravind
Target Milestone: rcKeywords: MigratedToJIRA, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-16 19:07:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matus Marhefka 2023-03-10 12:24:28 UTC
Description of problem:
Attempting to test if some grub2 binaries were properly built with stack protection yields skip: stack-prot test because sources compiled as if they were assembler are not checked by this test.

This means that these binaries were compiled without the annobin plugin but based on https://one.redhat.com/rhel-development-guide/#_changing_the_build_flags disabling annobin is not listed as one of the allowed changes.


Version-Release number of selected component (if applicable):
grub2-tools-2.06-61.el9
grub2-tools-minimal-2.06-61.el9
annobin-annocheck-11.05-1.el9


How reproducible:
always


Steps to Reproduce:
1. dnf install -y annobin-annocheck grub2-tools grub2-tools-minimal
2. dnf debuginfo-install -y grub2-tools grub2-tools-minimal
3. rpm -ql grub2-tools | grep -E '/usr/s?bin/' | while read f ; do test -L $f || echo $f ; done | xargs -- annocheck --verbose --skip-all --test-stack-prot
4. rpm -ql grub2-tools-minimal | grep -E '/usr/s?bin/' | while read f ; do test -L $f || echo $f ; done | xargs -- annocheck --verbose --skip-all --test-stack-prot


Actual results:
/usr/sbin/grub2-set-bootflag::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-probe::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-install::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-script-check::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mount::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkrelpath::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkpasswd-pbkdf2::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkimage::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-menulst2cfg::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-file::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-editenv::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-bios-setup::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-ofpathname::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test


Expected results:
No "skip: stack-prot test because sources compiled as if they were assembler are not checked by this test"


Additional info:

Comment 1 Marta Lewandowska 2023-03-24 15:29:03 UTC
We already have a bug open for the same issue for grub2-tools-minimal: https://bugzilla.redhat.com/show_bug.cgi?id=2148125 which we have proposed to fix in 9.3.
We can keep this one open for grub2-tools and probably fix both in the same release.

Comment 2 Jan Pazdziora (Red Hat) 2023-03-24 15:48:59 UTC
The problem is, with the 2.06-27.el9_0.x86_64 version for which bug 2148125 was filed, annocheck reported

Hardened: /usr/bin/grub2-mount: PASS: stack-prot test 

Here for 2.06-61.el9 we get

skip: stack-prot test because sources compiled as if they were assembler are not checked by this test

So it seems like some regression happened between RHEL 9.0 and the 9.2 build since for the RHEL 9.0 build the plugin was (likely) used because annocheck was happy with most of the binaries there. If there is a regression brewing for RHEL 9.2 compared to previous y-releases, maybe it should be prevented in RHEL 9.2.

Comment 4 RHEL Program Management 2023-09-16 18:15:30 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 5 RHEL Program Management 2023-09-16 19:07:08 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.