This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2177213 - Multiple grub2 binaries are not compiled with annobin plugin enabled
Summary: Multiple grub2 binaries are not compiled with annobin plugin enabled
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: grub2
Version: 9.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Bootloader engineering team
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-10 12:24 UTC by Matus Marhefka
Modified: 2023-09-16 19:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-16 19:07:08 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   RHEL-4357 0 None Migrated None 2023-09-16 19:07:00 UTC
Red Hat Issue Tracker RHELPLAN-151431 0 None None None 2023-03-10 12:26:08 UTC

Description Matus Marhefka 2023-03-10 12:24:28 UTC
Description of problem:
Attempting to test if some grub2 binaries were properly built with stack protection yields skip: stack-prot test because sources compiled as if they were assembler are not checked by this test.

This means that these binaries were compiled without the annobin plugin but based on https://one.redhat.com/rhel-development-guide/#_changing_the_build_flags disabling annobin is not listed as one of the allowed changes.


Version-Release number of selected component (if applicable):
grub2-tools-2.06-61.el9
grub2-tools-minimal-2.06-61.el9
annobin-annocheck-11.05-1.el9


How reproducible:
always


Steps to Reproduce:
1. dnf install -y annobin-annocheck grub2-tools grub2-tools-minimal
2. dnf debuginfo-install -y grub2-tools grub2-tools-minimal
3. rpm -ql grub2-tools | grep -E '/usr/s?bin/' | while read f ; do test -L $f || echo $f ; done | xargs -- annocheck --verbose --skip-all --test-stack-prot
4. rpm -ql grub2-tools-minimal | grep -E '/usr/s?bin/' | while read f ; do test -L $f || echo $f ; done | xargs -- annocheck --verbose --skip-all --test-stack-prot


Actual results:
/usr/sbin/grub2-set-bootflag::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-probe::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-install::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-script-check::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mount::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkrelpath::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkpasswd-pbkdf2::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-mkimage::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-menulst2cfg::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-file::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/bin/grub2-editenv::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-bios-setup::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test
/usr/sbin/grub2-ofpathname::skip: stack-prot test because sources compiled as if they were assembler are not checked by this test


Expected results:
No "skip: stack-prot test because sources compiled as if they were assembler are not checked by this test"


Additional info:

Comment 1 Marta Lewandowska 2023-03-24 15:29:03 UTC
We already have a bug open for the same issue for grub2-tools-minimal: https://bugzilla.redhat.com/show_bug.cgi?id=2148125 which we have proposed to fix in 9.3.
We can keep this one open for grub2-tools and probably fix both in the same release.

Comment 2 Jan Pazdziora (Red Hat) 2023-03-24 15:48:59 UTC
The problem is, with the 2.06-27.el9_0.x86_64 version for which bug 2148125 was filed, annocheck reported

Hardened: /usr/bin/grub2-mount: PASS: stack-prot test 

Here for 2.06-61.el9 we get

skip: stack-prot test because sources compiled as if they were assembler are not checked by this test

So it seems like some regression happened between RHEL 9.0 and the 9.2 build since for the RHEL 9.0 build the plugin was (likely) used because annocheck was happy with most of the binaries there. If there is a regression brewing for RHEL 9.2 compared to previous y-releases, maybe it should be prevented in RHEL 9.2.

Comment 4 RHEL Program Management 2023-09-16 18:15:30 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 5 RHEL Program Management 2023-09-16 19:07:08 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.


Note You need to log in before you can comment on or make changes to this bug.