Bug 217832
Summary: | Echo icon theme is not present in KDE control center | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Julian Sikorski <belegdol> | ||||||
Component: | echo-icon-theme | Assignee: | David Zeuthen <davidz> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | chitlesh, davidz, luya_tfz, markg85, martin.sourada, mclasen, rdieter, wade.nels | ||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | 0.3-3.git.fc8 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2008-02-19 13:58:04 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Julian Sikorski
2006-11-30 08:53:40 UTC
KDE problem, I would say. You think so? Then, this may be useful as well: [jsikorski@fcdesktop ~]$ kde-config --version Qt: 3.3.7 KDE: 3.5.5-0.2.fc6 Fedora-Core kde-config: 1.0 [jsikorski@fcdesktop ~]$ [root@Marks-PC Echo]# kde-config --version Qt: 3.3.7 KDE: 3.5.5-0.2.fc6 Fedora-Core kde-config: 1.0 [root@Marks-PC Echo]# That`s what i have and i have the exact same problem.. perhaps the index.theme file needs to be recreated? and where are the higher quality icons? because now the max size i can find is 48x48 I've a patch to fix the presence of echo theme on kcontrol. Which I'll upload soon. However to my point of view, there are lots of things to fix and improve in the icon set so that we can make it the default Icon set for Fedora KDE spin. A screenshot will also be attached. Created attachment 147310 [details]
screenshot on kde
Created attachment 147311 [details]
patch
Yup, MUSTFIX, before it can be considered for F7/kde's default icon set. Nope, randomly changing categories is a nonstarter Agreed, Chitlesh, you need to provide justification(s) for the patch. The original index.theme uses the following Context= Context=emotions Context=emblems Context=categories Context=status Context=actions Context=places Context=mimetypes Context=devices Context=apps Theses aren't according the freedesktop specification. kcontrol icon module doesn't seem to see the entry in index.theme unless it's a context it recognises http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#context I admit my patch having only Context=Actions isn't the best solution. But at least to pinpoint what could be the problem. I also think the bug is related to KDE because of the lack of 24x24 icons on most themes. Perhaps investigating that issue will be a good starting point. Well it is not really a problem of 22x22 or 24x24. I was wrong. Sounds like KDE dislikes symbolic links. take for example if you - delete 24x24/actions/up.png (which is a symbolic link) - copy and paste 24x24/actions/go-up.png as up.png - create a tarball - install the tarball via kcontrol you will see the up.png on your konqueror. So the kde bug (for the missing icons in the toolbar) is mostly related to symbolic links and not to missing 22x22. As David Zeuthen cares for space, we have to re-think how symbolic links should be made. User dfong's account has been closed ?? What happened to diana's account ? It has been closed, because she left Red Hat. Any timeline in addressing this? If not soon, we'll have to omit it from the kde spin/livecd, since it simply does not work in kde as-is. Nobody from the KDE side has come forward to explain a) what exactly is the problem that KDE has with echo b) what changes are necessary to fix this If KDE does not handle symlinks in icon themes correctly, as comment 12 seems to indicate, this really cannot be fixed in the echo-icon-theme. KDE or GNOME doesn't applied to FreeDesktop.org icon naming standard, so iconsset for KDE willn't work in GNOME and vice versa. Seems there are a few distinct issues here: 1. icon categories (see comment #8, comment #10) 2. symlinks (see comment #12) 3. kde's use/non-use of 22x22 vs. 24x24 sized icons. For (1), seems to be a simple case of applying the patch provided to make echo conform to icon-theme-spec. The latter ones, seem to be open (kde-specific) problems. Regarding the first point, there is currently some conflicting information, if you compare the icon theme spec and the icon naming spec. I think this needs to be clarified on xdg-list, I'll send a mail. Tango also uses categories from the icon naming spec. Does Tango work with kde ? yes, tango works (seems to for me anyway) fwiw, $ rpm -q tango-icon-theme tango-icon-theme-0.7.2-5.fc6 $ grep '^Context=' /usr/share/icons/Tango/index.theme | sort | uniq Context=Actions Context=Applications Context=Categories Context=Devices Context=Emblems Context=Emotes Context=MimeTypes Context=Places Context=Status So, it too includes some extra contexts referenced only in the naming-spec (not theme-spec), but I think these have been patched into kde. See http://bugs.kde.org/120562 and http://tango.freedesktop.org/Installation#Patches_to_KDE Looks to me that the patch as-is isn't correct, it's mostly just a matter of capitalizing the context targets. Indeed, seems Johns script to harvest the icons from the wiki has some shortcomings. I'm correcting the contexts for now, but there are more problems, e.g. I see 16x16/mimes/x-office-calendarS-.png, which is probably supposed to be 16x16/mimetypes/x-office-calendar.png. Please let me know if echo-icon-theme-0.2-3.20070419wiki.fc8 works better with kde, it has the contexts fixed. Closing bug as the issue is solved. Please reopen if similar problem occurs. Ugh, still no workie, $ rpm -q echo-icon-theme echo-icon-theme-0.2-2.20070419wiki.fc7.noarch We don't use Echo as the default theme so moving off the target list. Confirmed that echo-icon-theme-0.3-3.git.fc8 works (better, anyway). |