Bug 2178635
| Summary: | Review Request: gnome-shell-extension-dash-to-panel - Integrated icon taskbar and status panel for Gnome Shell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/home-sweet-gnome/dash-to-panel | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-26 00:18:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dominik 'Rathann' Mierzejewski
2023-03-15 13:39:10 UTC
Taking this review. Initial spec review: > # > Patch0: %{name}-system-install-paths.patch Missing comment? > %if 0%{?fedora} > Requires: libdbusmenu-gtk3 > %endif This package is present in EPEL 9, so you don't need to conditionalize this. > %{extdir} Please add a trailing slash so RPM unambiguously knows this is a directory. Fixed. Spec URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel.spec SRPM URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel-55-2.fc37.src.rpm * Wed Mar 15 2023 Dominik Mierzejewski <dominik> - 55-2 - correct run-time dependencies - add explicit slash to extdir - add missing comment Copr build: https://copr.fedorainfracloud.org/coprs/build/5649324 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178635-gnome-shell-extension-dash-to-panel/fedora-rawhide-x86_64/05649324-gnome-shell-extension-dash-to-panel/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This looks good to me. PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-dash-to-panel FEDORA-2023-79c7f4da2e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-79c7f4da2e FEDORA-2023-9682b23db3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9682b23db3 FEDORA-2023-9682b23db3 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9682b23db3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-79c7f4da2e has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-79c7f4da2e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-79c7f4da2e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-9682b23db3 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-79c7f4da2e has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |