Bug 2178635 - Review Request: gnome-shell-extension-dash-to-panel - Integrated icon taskbar and status panel for Gnome Shell
Summary: Review Request: gnome-shell-extension-dash-to-panel - Integrated icon taskbar...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/home-sweet-gnome/d...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-15 13:39 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2023-03-26 01:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-26 00:18:49 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2023-03-15 13:39:10 UTC
Spec URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel.spec
SRPM URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel-55-1.fc37.src.rpm
Description:
Dash to Panel is an icon taskbar for Gnome Shell. This extension moves the dash
into the gnome main panel so that the application launchers and system tray are
combined into a single panel, similar to that found in KDE Plasma and Windows
7+. A separate dock is no longer needed for easy access to running and favorited
applications.

Fedora Account System Username: rathann

Comment 1 Neal Gompa 2023-03-15 13:42:19 UTC
Taking this review.

Comment 2 Neal Gompa 2023-03-15 13:44:40 UTC
Initial spec review:

> #
> Patch0:         %{name}-system-install-paths.patch

Missing comment?

> %if 0%{?fedora}
> Requires:       libdbusmenu-gtk3
> %endif

This package is present in EPEL 9, so you don't need to conditionalize this.

> %{extdir}

Please add a trailing slash so RPM unambiguously knows this is a directory.

Comment 3 Dominik 'Rathann' Mierzejewski 2023-03-15 22:26:03 UTC
Fixed.

Spec URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel.spec
SRPM URL: https://rathann.fedorapeople.org/review/gnome-shell-extension-dash-to-panel/gnome-shell-extension-dash-to-panel-55-2.fc37.src.rpm

* Wed Mar 15 2023 Dominik Mierzejewski <dominik> - 55-2
- correct run-time dependencies
- add explicit slash to extdir
- add missing comment

Comment 4 Jakub Kadlčík 2023-03-15 22:33:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5649324
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2178635-gnome-shell-extension-dash-to-panel/fedora-rawhide-x86_64/05649324-gnome-shell-extension-dash-to-panel/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Neal Gompa 2023-03-16 00:37:54 UTC
This looks good to me.

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2023-03-16 08:00:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-dash-to-panel

Comment 7 Fedora Update System 2023-03-16 10:54:13 UTC
FEDORA-2023-79c7f4da2e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-79c7f4da2e

Comment 8 Fedora Update System 2023-03-16 10:54:14 UTC
FEDORA-2023-9682b23db3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9682b23db3

Comment 9 Fedora Update System 2023-03-18 05:12:58 UTC
FEDORA-2023-9682b23db3 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9682b23db3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-03-18 06:07:51 UTC
FEDORA-2023-79c7f4da2e has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-79c7f4da2e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-79c7f4da2e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-26 00:18:49 UTC
FEDORA-2023-9682b23db3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-03-26 01:20:39 UTC
FEDORA-2023-79c7f4da2e has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.