Bug 2179313

Summary: dmapd: Calls internal, undeclared vips_foreign_load function
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: dmapdAssignee: W. Michael Petullo <redhat>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: epel-packagers-sig, mike, redhat
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dmapd-0.0.92-2.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-18 18:38:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    
Attachments:
Description Flags
dmapd-c99.patch none

Description Florian Weimer 2023-03-17 10:06:24 UTC 
The vips package does not declare the vips_foreign_load in any header file, so presumably it's an internal function. But dmapd calls it from photo-meta-reader-vips.c. This will stop to work by accident once compilers no longer support implicit function declarations.

Filing this here because upstream does not seem to have bug tracker or mailing list.
Comment 1 Florian Weimer 2023-03-17 10:28:56 UTC 
Created attachment 1951449 [details]
dmapd-c99.patch

I came up with a kludge to keep the package building. I'm going to leave this bug open, so that hopefully a proper fix can be implemented.
Comment 2 W. Michael Petullo 2023-03-18 18:38:09 UTC 
This had evidently  missed my eye for a long time. Fixed properly upstream in 0.0.93. Thank you for the report---the new GCC's approach is forcing our hand to fix a number of little issues. This is good!