Bug 2179313 - dmapd: Calls internal, undeclared vips_foreign_load function
Summary: dmapd: Calls internal, undeclared vips_foreign_load function
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dmapd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: W. Michael Petullo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2023-03-17 10:06 UTC by Florian Weimer
Modified: 2023-03-18 18:38 UTC (History)
3 users (show)

Fixed In Version: dmapd-0.0.92-2.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-18 18:38:09 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
dmapd-c99.patch (584 bytes, patch)
2023-03-17 10:28 UTC, Florian Weimer 		no flags Details | Diff
View All

Description Florian Weimer 2023-03-17 10:06:24 UTC 
The vips package does not declare the vips_foreign_load in any header file, so presumably it's an internal function. But dmapd calls it from photo-meta-reader-vips.c. This will stop to work by accident once compilers no longer support implicit function declarations.

Filing this here because upstream does not seem to have bug tracker or mailing list.
Comment 1 Florian Weimer 2023-03-17 10:28:56 UTC 
Created attachment 1951449 [details]
dmapd-c99.patch

I came up with a kludge to keep the package building. I'm going to leave this bug open, so that hopefully a proper fix can be implemented.
Comment 2 W. Michael Petullo 2023-03-18 18:38:09 UTC 
This had evidently  missed my eye for a long time. Fixed properly upstream in 0.0.93. Thank you for the report---the new GCC's approach is forcing our hand to fix a number of little issues. This is good!
Note You need to log in before you can comment on or make changes to this bug.