Bug 2181023

Summary: Review Request: rust-event-manager - Abstractions for implementing event based systems
Product: [Fedora] Fedora Reporter: fedora.dm0
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/event-manager
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-28 15:12:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2141389    
Bug Blocks: 2181039    

Description fedora.dm0 2023-03-22 21:35:18 UTC
Spec URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-event-manager.spec
SRPM URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-event-manager-0.3.0-1.fc37.src.rpm
Description: Abstractions for implementing event based systems.
Fedora Account System Username: dm0

This is a dependency of Firecracker.  The spec is automatically generated, except to add a patch to drop criterion (for benchmarks, unused) and for enabling the test_utilities feature in %check.

Comment 1 Jakub Kadlčík 2023-03-22 21:39:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5696241
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181023-rust-event-manager/fedora-rawhide-x86_64/05696241-rust-event-manager/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-23 14:15:31 UTC
Package doesn't currently build.

Looks like the vmm-sys-util v0.11.1 update (among others) was not submitted to rawhide at all:
https://bugzilla.redhat.com/show_bug.cgi?id=2141389#c3

Comment 3 fedora.dm0 2023-03-24 14:31:54 UTC
I've updated this package to drop CODEOWNERS and coverage_config* files and to flag additional files as documentation.

Comment 4 Fabio Valentini 2023-03-27 16:58:26 UTC
Comments from https://bugzilla.redhat.com/show_bug.cgi?id=2181025#c4 also apply equally to this package.

Comment 5 fedora.dm0 2023-03-27 22:36:58 UTC
The spec and SRPM are updated to exclude docs and add comments.

Comment 6 Fabio Valentini 2023-03-28 14:39:21 UTC
Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR BSD-3-Clause) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 7 Fedora Admin user for bugzilla script actions 2023-03-28 14:50:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-event-manager

Comment 8 Fedora Update System 2023-03-28 15:09:07 UTC
FEDORA-2023-300fcc5215 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-300fcc5215

Comment 9 Fedora Update System 2023-03-28 15:12:04 UTC
FEDORA-2023-300fcc5215 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-03-28 19:44:19 UTC
FEDORA-2023-02106a6c13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

Comment 11 Fedora Update System 2023-03-28 19:44:21 UTC
FEDORA-2023-a4085b6295 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

Comment 12 Fedora Update System 2023-03-29 02:02:22 UTC
FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-03-29 03:55:50 UTC
FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4085b6295 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-03-30 01:19:42 UTC
FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-03-31 01:33:51 UTC
FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.