Bug 2181676
| Summary: | Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Adams <linux> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/cmadamsgit/%{name} | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Chris Adams
2023-03-25 00:01:08 UTC
An alternate setup: since the plugins are independent, put them into separate RPMs Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins-cmadams.spec SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins-cmadams-0-0.2.20230208git1d05426.fc37.src.rpm I initially started with just bundling them together, but being able to install them separately probably makes more sense. Created attachment 1955617 [details]
The .spec file difference from Copr build 5706893 to 5740123
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. It'd still be nice to get this reviewed; I feel the plugins would be useful to more than just myself. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. I think this would still be a useful monitoring package. Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/9819256 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/09819256-nagios-plugins-cmadams/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated: Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams.spec SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams-0-0.2.gitfbe717d.fc44.src.rpm Created attachment 2115929 [details]
The .spec file difference from Copr build 9819256 to 9830853
Copr build: https://copr.fedorainfracloud.org/coprs/build/9830853 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/09830853-nagios-plugins-cmadams/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated: Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams.spec SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams-0-0.3.gitb5712e3.fc43.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/10207644 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/10207644-nagios-plugins-cmadams/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated with a few more tweaks: Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams.spec SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams-0-0.4.20260312git371b655.fc43.src.rpm Created attachment 2133230 [details]
The .spec file difference from Copr build 10207644 to 10220028
Copr build: https://copr.fedorainfracloud.org/coprs/build/10220028 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/10220028-nagios-plugins-cmadams/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |