Bug 2181676 - Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins
Summary: Review Request: nagios-plugins-cmadams - Miscellaneous Nagios plugins
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/cmadamsgit/%{name}
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-25 00:01 UTC by Chris Adams
Modified: 2025-11-23 20:37 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 5706893 to 5740123 (2.80 KB, patch)
2023-04-03 22:04 UTC, Jakub Kadlčík
no flags Details | Diff
The .spec file difference from Copr build 9819256 to 9830853 (2.24 KB, patch)
2025-11-23 20:37 UTC, Fedora Review Service
no flags Details | Diff

Description Chris Adams 2023-03-25 00:01:08 UTC
Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams.spec
SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/nagios-plugins-cmadams-0-0.1.20230208git1d05426.fc37.src.rpm
Description: These are some useful Nagios monitoring plugins:

- check_cert: This plugin makes an SSL/TLS connection to the specified
  server/port, validates the cert, and warns/errors on the number of
  days until the cert expires. It can be set to check an RSA or ECDSA
  cert, and can check some types of connections using STARTTLS.

- check_chrony: This plugin checks the selected chrony NTP server using
  the "chronyc" command line client.

- check_smtp_msg: This plugin makes a connection to an SMTP server,
  sends a message, and checks the result.

Fedora Account System Username: cmadams

Comment 1 Chris Adams 2023-04-03 21:56:46 UTC
An alternate setup: since the plugins are independent, put them into separate RPMs

Spec URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins-cmadams.spec
SRPM URL: https://cmadams.fedorapeople.org/nagios-plugins-cmadams/split/nagios-plugins-cmadams-0-0.2.20230208git1d05426.fc37.src.rpm

I initially started with just bundling them together, but being able to install them separately probably makes more sense.

Comment 2 Jakub Kadlčík 2023-04-03 22:04:11 UTC
Created attachment 1955617 [details]
The .spec file difference from Copr build 5706893 to 5740123

Comment 3 Package Review 2024-04-03 00:45:32 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Chris Adams 2024-04-03 16:44:49 UTC
It'd still be nice to get this reviewed; I feel the plugins would be useful to more than just myself.

Comment 5 Package Review 2025-04-04 00:45:26 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Chris Adams 2025-04-04 01:34:04 UTC
I think this would still be a useful monitoring package.

Comment 7 Fedora Review Service 2025-11-20 13:01:35 UTC
Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Comment 8 Fedora Review Service 2025-11-20 13:12:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9819256
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/09819256-nagios-plugins-cmadams/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2025-11-23 20:37:04 UTC
Created attachment 2115929 [details]
The .spec file difference from Copr build 9819256 to 9830853

Comment 11 Fedora Review Service 2025-11-23 20:37:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9830853
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181676-nagios-plugins-cmadams/fedora-rawhide-x86_64/09830853-nagios-plugins-cmadams/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.