Bug 2182474

Summary: Review Request: rust-castaway - Safe, zero-cost downcasting for limited compile-time specialization
Product: [Fedora] Fedora Reporter: Maxwell G <maxwell>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/castaway
Whiteboard:
Fixed In Version: rust-castaway-0.2.2-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-28 23:10:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2182542    

Description Maxwell G 2023-03-28 18:46:26 UTC
Spec URL: https://gotmax23.fedorapeople.org/reviews/rust-castaway/rust-castaway.spec
SRPM URL: https://gotmax23.fedorapeople.org/reviews/rust-castaway/rust-castaway-0.2.2-1.fc37.src.rpm

Description:
Safe, zero-cost downcasting for limited compile-time specialization.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99249123

Comment 1 Jakub Kadlčík 2023-03-28 18:54:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5718830
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182474-rust-castaway/fedora-rawhide-x86_64/05718830-rust-castaway/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-28 19:51:27 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification ("MIT") and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-03-28 22:52:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-castaway

Comment 4 Fedora Update System 2023-03-28 23:04:09 UTC
FEDORA-2023-b6d9ce02b2 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b6d9ce02b2

Comment 5 Fedora Update System 2023-03-28 23:05:28 UTC
FEDORA-2023-02616d2cc2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2

Comment 6 Fedora Update System 2023-03-28 23:05:30 UTC
FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

Comment 7 Fedora Update System 2023-03-28 23:05:32 UTC
FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

Comment 8 Fedora Update System 2023-03-28 23:10:13 UTC
FEDORA-2023-b6d9ce02b2 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-03-29 02:02:37 UTC
FEDORA-2023-02616d2cc2 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-03-29 02:39:17 UTC
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-29 03:56:05 UTC
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-04-03 14:53:10 UTC
FEDORA-2023-02616d2cc2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2

Comment 13 Fedora Update System 2023-04-03 19:45:29 UTC
FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

Comment 14 Fedora Update System 2023-04-03 19:48:09 UTC
FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

Comment 15 Fedora Update System 2023-04-03 20:01:11 UTC
FEDORA-2023-02616d2cc2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2

Comment 16 Fedora Update System 2023-04-03 20:05:42 UTC
FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

Comment 17 Fedora Update System 2023-04-04 02:28:06 UTC
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2023-04-04 02:37:22 UTC
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2023-04-12 01:32:25 UTC
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2023-04-12 01:38:18 UTC
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.