Bug 2182542 - Review Request: rust-compact_str - Memory efficient string type
Summary: Review Request: rust-compact_str - Memory efficient string type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/compact_str
Whiteboard:
Depends On: 2182474
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-29 01:25 UTC by Maxwell G
Modified: 2023-04-12 01:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-03 08:55:16 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Maxwell G 2023-03-29 01:25:54 UTC
Spec URL: https://gotmax23.fedorapeople.org/reviews/rust-compact_str/rust-compact_str.spec
SRPM URL: https://gotmax23.fedorapeople.org/reviews/rust-compact_str/rust-compact_str-0.7.0-1.fc37.src.rpm

Description:
A memory efficient string type that transparently stores strings on the
stack, when possible.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99263674

Comment 1 Jakub Kadlčík 2023-03-29 01:29:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5721299
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182542-rust-compact_str/fedora-rawhide-x86_64/05721299-rust-compact_str/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-04-02 10:40:49 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (missing dependencies for tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Disabling the test suite is justified, packaging a handful of crates just to run tests in one crate is not necessary.

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-04-03 08:36:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-compact_str

Comment 5 Fedora Update System 2023-04-03 08:54:21 UTC
FEDORA-2023-bd29748c07 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bd29748c07

Comment 6 Fedora Update System 2023-04-03 08:55:16 UTC
FEDORA-2023-bd29748c07 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-04-03 19:48:14 UTC
FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

Comment 8 Fedora Update System 2023-04-03 20:05:39 UTC
FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

Comment 9 Fedora Update System 2023-04-04 02:28:08 UTC
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-04-04 02:37:24 UTC
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-04-12 01:32:27 UTC
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-04-12 01:38:20 UTC
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.