Bug 2183204

Summary: Review Request: rust-anstream - Simple cross platform library for writing colored text to a terminal
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Aleksei Bavshin <alebastr89>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: alebastr89, package-review
Target Milestone: ---Flags: alebastr89: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/anstream
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-08 22:24:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2176563, 2183200, 2183202, 2183203    
Bug Blocks: 2174601, 2178703, 2178736, 2178737, 2183661    

Description Fabio Valentini 2023-03-30 14:56:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-anstream.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-anstream-0.2.6-1.fc38.src.rpm

Description:
A simple cross platform library for writing colored text to a terminal.

Fedora Account System Username: decathorpe

Comment 1 Jakub Kadlčík 2023-03-30 15:18:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5730285
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183204-rust-anstream/fedora-rawhide-x86_64/05730285-rust-anstream/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-30 19:56:29 UTC
Here's a COPR build against all the missing dependencies:
https://copr.fedorainfracloud.org/coprs/decathorpe/clap-anstream-concolor/build/5731025/

Comment 3 Aleksei Bavshin 2023-04-03 04:04:03 UTC
The package was generated with rust2rpm, simplifying the review. No issues with license or dependencies and the patches looks correct.

LGTM. Approved.

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-03 08:07:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-anstream

Comment 5 Fedora Update System 2023-04-08 22:20:21 UTC
FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc

Comment 6 Fedora Update System 2023-04-08 22:24:30 UTC
FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.