Bug 2183661 - Review Request: rust-clap_builder - Simple to use, efficient, and full-featured Command Line Argument Parser
Summary: Review Request: rust-clap_builder - Simple to use, efficient, and full-featur...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/clap_builder
Whiteboard:
Depends On: 2182231 2183200 2183204
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-31 23:23 UTC by Fabio Valentini
Modified: 2023-04-08 22:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-08 22:24:36 UTC
Type: ---
Embargoed:
alebastr89: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-03-31 23:23:44 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-clap_builder.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-clap_builder-4.2.1-1.fc38.src.rpm

Description:
A simple to use, efficient, and full-featured Command Line Argument
Parser.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-03-31 23:24:34 UTC
Successful COPR build with all dependencies available:
https://copr.fedorainfracloud.org/coprs/decathorpe/clap-anstream-concolor/build/5732601/

Comment 2 Jakub Kadlčík 2023-03-31 23:27:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5734012
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183661-rust-clap_builder/fedora-rawhide-x86_64/05734012-rust-clap_builder/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Aleksei Bavshin 2023-04-04 05:10:46 UTC
> # * missing dev-dependencies: snapbox, trycmd

Same as with clap_mangen, the tests that actually require snapbox, trybuild, trycmd are not included into the crate. But this time there are library and doc tests which require unpackaged `unic-emoji-char` and `color-print` respectively.
Please, update the comment with actual missing test deps before importing the package.

Looks good otherwise. Approved.

Comment 4 Fabio Valentini 2023-04-08 20:10:46 UTC
Thanks for the review! And good catch. I will update the comment before import.

Comment 5 Fedora Admin user for bugzilla script actions 2023-04-08 20:11:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap_builder

Comment 6 Fedora Update System 2023-04-08 22:20:23 UTC
FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc

Comment 7 Fedora Update System 2023-04-08 22:24:36 UTC
FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.