Bug 2183661
| Summary: | Review Request: rust-clap_builder - Simple to use, efficient, and full-featured Command Line Argument Parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Aleksei Bavshin <alebastr89> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alebastr89, package-review |
| Target Milestone: | --- | Flags: | alebastr89:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/clap_builder | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-08 22:24:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2182231, 2183200, 2183204 | ||
| Bug Blocks: | |||
|
Description
Fabio Valentini
2023-03-31 23:23:44 UTC
Successful COPR build with all dependencies available: https://copr.fedorainfracloud.org/coprs/decathorpe/clap-anstream-concolor/build/5732601/ Copr build: https://copr.fedorainfracloud.org/coprs/build/5734012 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183661-rust-clap_builder/fedora-rawhide-x86_64/05734012-rust-clap_builder/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > # * missing dev-dependencies: snapbox, trycmd
Same as with clap_mangen, the tests that actually require snapbox, trybuild, trycmd are not included into the crate. But this time there are library and doc tests which require unpackaged `unic-emoji-char` and `color-print` respectively.
Please, update the comment with actual missing test deps before importing the package.
Looks good otherwise. Approved.
Thanks for the review! And good catch. I will update the comment before import. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap_builder FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |