Bug 2183865

Summary: Review Request: rust-arrayref - Macros to take array references of slices
Product: [Fedora] Fedora Reporter: Aleksei Bavshin <alebastr89>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-02 22:19:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2183862, 2183866    

Description Aleksei Bavshin 2023-04-02 19:36:43 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-arrayref/rust-arrayref.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-arrayref/rust-arrayref-0.3.7-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
Macros to take array references of slices.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-04-20 19:49:16 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

(Though the quickcheck 0.6 dev-dependency is *really really old*, you might want to poke upstream to update that at some point.)

===

For the record, I am currently the "main admin" / maintainer of record of this package, but I agree with you becoming the new maintainer after un-retirement. Feel free to file the un-retirement ticket now.

Comment 2 Fabio Valentini 2023-05-02 22:19:49 UTC
Package unretirement was processed and updated package was built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-78fc214e12