Bug 2183866 - Review Request: rust-tiny-skia - Tiny Skia subset ported to Rust
Summary: Review Request: rust-tiny-skia - Tiny Skia subset ported to Rust
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2183862 2183865
Blocks: 2183860
TreeView+ depends on / blocked
 
Reported: 2023-04-02 19:41 UTC by Aleksei Bavshin
Modified: 2023-05-03 02:33 UTC (History)
2 users (show)

Fixed In Version: rust-tiny-skia-0.8.4-1.fc39
Clone Of:
Environment:
Last Closed: 2023-05-03 02:33:12 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2023-04-02 19:41:00 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-tiny-skia/rust-tiny-skia.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-tiny-skia/rust-tiny-skia-0.8.3-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
A tiny Skia subset ported to Rust.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-05-01 19:21:21 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.8.3 vs v0.9.0)
- license matches upstream specification (BSD-3-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

There's a lot of images in the "tests" directory, you might want to add `exclude = ["/tests/"]` to Cargo.toml, similar to how other packages with large test data handle this.

Note that the latest version is v0.9.0, but if we explicitly need v0.8.* for updating alacritty, then sticking with v0.8.3 for now is fine.

Comment 2 Aleksei Bavshin 2023-05-03 02:33:12 UTC
Thanks for the review!

Unretired and built for rawhide (https://bodhi.fedoraproject.org/updates/FEDORA-2023-42f74f3ec1)


Note You need to log in before you can comment on or make changes to this bug.