Bug 2183866

Summary:	Review Request: rust-tiny-skia - Tiny Skia subset ported to Rust
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-tiny-skia-0.8.4-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-03 02:33:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2183862, 2183865
Bug Blocks:	2183860

Description Aleksei Bavshin 2023-04-02 19:41:00 UTC

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-tiny-skia/rust-tiny-skia.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-tiny-skia/rust-tiny-skia-0.8.3-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
A tiny Skia subset ported to Rust.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-05-01 19:21:21 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.8.3 vs v0.9.0)
- license matches upstream specification (BSD-3-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

There's a lot of images in the "tests" directory, you might want to add `exclude = ["/tests/"]` to Cargo.toml, similar to how other packages with large test data handle this.

Note that the latest version is v0.9.0, but if we explicitly need v0.8.* for updating alacritty, then sticking with v0.8.3 for now is fine.

Comment 2 Aleksei Bavshin 2023-05-03 02:33:12 UTC

Thanks for the review!

Unretired and built for rawhide (https://bodhi.fedoraproject.org/updates/FEDORA-2023-42f74f3ec1)