Bug 2184722
| Summary: | Review Request: rust-gdk4-wayland - Rust bindings of the GDK 4 Wayland library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/gdk4-wayland | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-27 11:10:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2184719 | ||
| Bug Blocks: | 2184729 | ||
|
Description
Kalev Lember
2023-04-05 13:52:54 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5745877 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184722-rust-gdk4-wayland/fedora-rawhide-x86_64/05745877-rust-gdk4-wayland/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This package is missing a lot of subpackages for optional features: - dox - egl - khronos-egl - wayland-backend - wayland_crate - xkb What's the reasoning behind their removal? And are you sure that you do not need these features? We are missing some deps - the egl crate at least, if I remember right. I just wanted to get a subset in first and then look at adding more optional features. If that is the way you want to handle this, that's fine with me. I was only confused by the lack of subpackages, which is likely configured in rust2rpm.conf that's not linked into this review request (and hence not documented). :) === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-wayland Thanks for the review! Package imported and rawhide build under way. (In reply to Fabio Valentini from comment #4) > If that is the way you want to handle this, that's fine with me. > I was only confused by the lack of subpackages, which is likely configured > in rust2rpm.conf that's not linked into this review request (and hence not > documented). :) Yep, exactly :) I wonder if we should maybe start adding rust2rpm.conf to rpm Sources so it's always included in the source rpm? Is this something rust2rpm could do? FEDORA-2023-236513bc46 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-236513bc46 FEDORA-2023-236513bc46 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |