Bug 2184719 - Review Request: rust-gdk4-wayland-sys - FFI bindings of GDK4 Wayland
Summary: Review Request: rust-gdk4-wayland-sys - FFI bindings of GDK4 Wayland
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gdk4-wayland...
Whiteboard:
Depends On:
Blocks: 2184722
TreeView+ depends on / blocked
 
Reported: 2023-04-05 13:44 UTC by Kalev Lember
Modified: 2023-04-21 20:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-21 20:37:06 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2023-04-05 13:44:10 UTC
Spec URL: https://kalev.fedorapeople.org/rust-gdk4-wayland-sys.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-wayland-sys-0.6.3-1.fc39.src.rpm
Description: FFI bindings of GDK4 Wayland.
Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99555853

Comment 1 Jakub Kadlčík 2023-04-05 13:53:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745868
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184719-rust-gdk4-wayland-sys/fedora-rawhide-x86_64/05745868-rust-gdk4-wayland-sys/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-04-20 20:10:12 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I assume that you created a rust2rpm.conf file to add BuildRequires / Requires to the respective subpackages? Make sure to also import that.

Comment 3 Kalev Lember 2023-04-21 20:15:10 UTC
Thanks for the review! Yes, I created a rust2rpm.conf and have it in local git.

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-21 20:15:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-wayland-sys

Comment 5 Fedora Update System 2023-04-21 20:34:42 UTC
FEDORA-2023-29d8d479ae has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-29d8d479ae

Comment 6 Fedora Update System 2023-04-21 20:37:06 UTC
FEDORA-2023-29d8d479ae has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.